Conversation
ivannizh
reviewed
Mar 21, 2025
ivannizh
left a comment
ivannizh
left a comment
There was a problem hiding this comment.
Привет! Хорошая работа! Осталось исправить некоторые моменты и работа будет принята.
| } | ||
| steps, err := strconv.Atoi(res[0]) | ||
| if err != nil { | ||
| return 0, "", 0, errors.New("невозможно преобразовать элемент слайса в int") |
There was a problem hiding this comment.
- Теряешь сообщение об ошибки
- Ошибку лучше писать на английском
Suggested change
| return 0, "", 0, errors.New("невозможно преобразовать элемент слайса в int") | |
| return 0, 0, fmt.Errorf("conversion error: %w", err) |
| if err != nil { | ||
| return 0, "", 0, errors.New("невозможно преобразовать элемент слайса в int") | ||
| } | ||
| duration, err := time.ParseDuration(res[2]) |
There was a problem hiding this comment.
Нет проверки длительности на меньше или равно 0
| } | ||
| steps, err := strconv.Atoi(res[0]) | ||
| if err != nil { | ||
| return 0, 0, errors.New("невозможно преобразовать элемент слайса в int") |
There was a problem hiding this comment.
- Теряешь сообщение об ошибки
- Ошибку лучше писать на английском
Suggested change
| return 0, 0, errors.New("невозможно преобразовать элемент слайса в int") | |
| return 0, 0, fmt.Errorf("conversion error: %w", err) |
| if err != nil { | ||
| return 0, 0, errors.New("невозможно преобразовать элемент слайса в int") | ||
| } | ||
| if steps <= 0 { |
| if steps <= 0 { | ||
| return 0, 0, errors.New("количество шагов меньше или равно 0") | ||
| } | ||
| duration, err := time.ParseDuration(res[1]) |
There was a problem hiding this comment.
Нет проверки длительности на меньше или равно 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.